Re: [pcre-dev] PCRE2: Unnecessary substring number checks?

Top Page
Delete this message
Author: ph10
Date:  
To: Ralf Junker
CC: pcre-dev
Subject: Re: [pcre-dev] PCRE2: Unnecessary substring number checks?
On Thu, 11 Dec 2014, Ralf Junker wrote:

> Assuming that pcre2_dfa_match() would work just like pcre2_match(), I
> next checked if this also links a compiled pattern code to a
> match_data. Surprisingly, it does not. Pre-filling a match_pattern's
> memory with NULLs, match_data->code is left unchanged by
> pcre2_dfa_match().
>
> A consecutive call to pcre2_substring_get_bynumber() et. al. results
> in an access violation.


Oops.

> Are the pcre2_substring_...() functions not intended for use with
> pcre2_dfa_match()?


Yes, they are, and you have found a nasty bug, which I will of course
fix. Thank you again for all this testing and checking. It is most
useful. I expect to start working through your comments tomorrow
(it's been a busy with with Real Life (tm)).

Philip

--
Philip Hazel