[exim-cvs] Avoid segfault on ref:name specified as uid.

Página superior

Responder a este mensaje
Autor: Exim Git Commits Mailing List
Fecha:  
A: exim-cvs
Asunto: [exim-cvs] Avoid segfault on ref:name specified as uid.
Gitweb: http://git.exim.org/exim.git/commitdiff/084c1d8c14da86888bbffc31a54246dc6e2e8147
Commit:     084c1d8c14da86888bbffc31a54246dc6e2e8147
Parent:     bdff9439baec7646a48684b8ddc0d50dd8fbffb3
Author:     Phil Pennock <pdp@???>
AuthorDate: Tue Mar 22 22:28:33 2011 -0400
Committer:  Phil Pennock <pdp@???>
CommitDate: Tue Mar 22 22:28:33 2011 -0400


    Avoid segfault on ref:name specified as uid.


    If group not also specified, make this a fatal error.  If group
    specified, we'll error out anyway unless the group can be resolved.


    Approach considered but not followed: fatal config error if built with
    ref:name where name is a number.


    fixes bug 1098
---
 doc/doc-txt/ChangeLog |    3 +++
 src/src/exim.c        |   14 +++++++++++++-
 2 files changed, 16 insertions(+), 1 deletions(-)


diff --git a/doc/doc-txt/ChangeLog b/doc/doc-txt/ChangeLog
index 7105e5f..2b3ec85 100644
--- a/doc/doc-txt/ChangeLog
+++ b/doc/doc-txt/ChangeLog
@@ -15,6 +15,9 @@ PP/03 New openssl_options items: no_sslv2 no_sslv3 no_ticket no_tlsv1

PP/04 New "dns_use_edns0" global option.

+PP/05 Don't segfault on misconfiguration of ref:name exim-user as uid.
+      Bugzilla 1098.
+


 Exim version 4.75
 -----------------
diff --git a/src/src/exim.c b/src/src/exim.c
index 30974c9..528ffc7 100644
--- a/src/src/exim.c
+++ b/src/src/exim.c
@@ -1414,7 +1414,19 @@ if (route_finduser(US EXIM_USERNAME, &pw, &exim_uid))
       EXIM_USERNAME);
     exit(EXIT_FAILURE);
     }
-  exim_gid = pw->pw_gid;
+  /* If ref:name uses a number as the name, route_finduser() returns
+  TRUE with exim_uid set and pw coerced to NULL. */
+  if (pw)
+    exim_gid = pw->pw_gid;
+#ifndef EXIM_GROUPNAME
+  else
+    {
+    fprintf(stderr,
+        "exim: ref:name should specify a usercode, not a group.\n"
+        "exim: can't let you get away with it unless you also specify a group.\n");
+    exit(EXIT_FAILURE);
+    }
+#endif
   }
 else
   {