[exim-dev] [Bug 905] Typo, signed/unsigned char Exim-4.70 C…

Top Page
Delete this message
Reply to this message
Author: Serge Demonchaux
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 905] Typo, signed/unsigned char Exim-4.70 CVS (2009-11-09 18:29:22 +0100)
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905




--- Comment #7 from Serge Demonchaux <serge-exim@???> 2009-11-11 15:14:14 ---
> More signed/unsigned fixes. Need confirmation that this completely deals
> with bug. Related: bug#905


src/dns.c         ===> OK
src/dcc.c         ===> OK
src/malware.c     ===> OK
src/mime.c        ===> OK
src/receive.c     ===> OK
src/spf.c         ===> OK
src/lookups/spf.c ===> OK




------- Comment #6 From Nigel Metheringham 2009-11-11 14:45:03
> We need to change those config.h changes to a Makefile or buildconfig.c
> patch.


...or to leave the choie to the packager? I would not be to answer.
Call the list about this ?


See more about 'off_t' with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
<http://lists.freebsd.org/pipermail/freebsd-arch/2005-December/004685.html>

In Linux x86 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 8

In Linux x86 withOUT "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == i686
sizeof(test_off_t) == 4

In Linux x86_64 with "-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE":
$ uname -m == x86_64
sizeof(test_off_t) == 8

=============start=====================
--- exim-4.70/src/buildconfig.c.ORI      2009-11-11 15:05:15 +0100
+++ exim-4.70/src/buildconfig.c  2009-11-11 15:05:33 +0100
@@ -147,8 +147,8 @@
 fprintf(new, "#ifndef OFF_T_FMT\n");
 if (sizeof(test_off_t) > 4)
   {
-  fprintf(new, "#define OFF_T_FMT  \"%%lld\"\n");
-  fprintf(new, "#define LONGLONG_T long long int\n");
+  fprintf(new, "#define OFF_T_FMT  \"%%\" PRIi64\n");
+  fprintf(new, "#define LONGLONG_T int64_t\n");
   }
 else
   {
@@ -165,9 +165,9 @@
 fprintf(new, "#ifndef TIME_T_FMT\n");
 if (sizeof(test_time_t) > 4)
   {
-  fprintf(new, "#define TIME_T_FMT  \"%%lld\"\n");
+  fprintf(new, "#define TIME_T_FMT  \"%%\" PRIi64\n");
   fprintf(new, "#undef  LONGLONG_T\n");
-  fprintf(new, "#define LONGLONG_T long long int\n");
+  fprintf(new, "#define LONGLONG_T int64_t\n");
   }
 else
   {
=============end=====================




Best regards,
--Serge


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email