[exim-dev] [Bug 905] Typo, signed/unsigned char Exim-4.70 C…

------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=905

Serge Demonchaux <serge-exim@???> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |serge-exim@???

--- Comment #4 from Serge Demonchaux <serge-exim@???> 2009-11-11 13:29:48 ---
Very good.

src/dns.c       ===> OK
src/dcc.c       ===> OK
src/malware.c   ===> OK
src/mime.c      ===> OK
src/receive.c   ===> OK
src/spf.c       ===> OK

I'm missed this 'src/lookups/spf.c'
========================
--- /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c.ORI 2009-11-11 
12:00:26 +0100
+++ /caos.dev/usr/src/rpm/BUILD/exim-4.70CVS/src/lookups/spf.c     2009-11-11 
12:00:17 +0100
@@ -59,11 +59,11 @@
     return FAIL;
   }

-  if (SPF_request_set_ipv4_str(spf_request, filename)) {
+  if (SPF_request_set_ipv4_str(spf_request, CS filename)) {
     *errmsg = string_sprintf("invalid IP address '%s'", filename);
     return FAIL;
   }
-  if (SPF_request_set_env_from(spf_request, keystring)) {
+  if (SPF_request_set_env_from(spf_request, CS keystring)) {
     *errmsg = string_sprintf("invalid envelope from address '%s'", 
keystring);
     return FAIL;
   }
========================

With Linux i386 + GCC (-Wall), Exim is compiled well. On the x86_64
AMD , there are problems with 'off_t': (build-Linux-x86_64/config.h)

#ifndef OFF_T_FMT
#define OFF_T_FMT "%lld"
#define LONGLONG_T long long int
#endif


[...]
appendfile.c:2641: warning: format '%lld' expects type 'long long int', but
argument 3 has type 'off_t'
[...]


by changing the definitions, i have no warnings

build-Linux-x86_64/config.h:

--- exim-4.70/build-Linux-x86_64/config.h.ORI    2009-11-11 14:24:47 +0100
+++ exim-4.70/build-Linux-x86_64/config.h        2009-11-11 14:25:54 +0100
@@ -7,12 +7,12 @@
 Do not edit it. Instead, edit Local/Makefile and rerun make. */

#ifndef OFF_T_FMT
-#define OFF_T_FMT "%lld"
+#define OFF_T_FMT "%" PRIi64
#define LONGLONG_T int64_t
#endif

#ifndef TIME_T_FMT
-#define TIME_T_FMT "%lld"
+#define TIME_T_FMT "%" PRIi64
#undef LONGLONG_T
#define LONGLONG_T int64_t
#endif



Regards,
--Serge


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email