[pcre-dev] [Bug 821] Unused struct members

Page principale
Supprimer ce message
Auteur: bill
Date:  
À: pcre-dev
Sujet: [pcre-dev] [Bug 821] Unused struct members
------- You are receiving this mail because: -------
You are on the CC list for the bug.

http://bugs.exim.org/show_bug.cgi?id=821




--- Comment #2 from bill <begert@???> 2009-03-11 12:48:55 ---
(In reply to comment #1)
> On Tue, 10 Mar 2009, bill wrote:
>
> > Using cppcheck 1.30 against PCRE 7.8 yields:
> >
> > # cppcheck -s -q .
> > [pcre_exec.c:337]: (style) struct or union member 'heapframe::Xcharptr' is
> > never
> > used
> > [pcre_exec.c:359]: (style) struct or union member 'heapframe::Xoclength' is
> > never used
> > [pcre_exec.c:360]: (style) struct or union member 'heapframe::Xocchars' is
> > never
> > used
> >
> >
> > This is not really a bug but just pointing out some possible unnecessary
> > members of the struct "heapframe"
> >
> > I commented them out and tested with default settings and with SUPPORT_UCP
> > defined with no compilation errors.
>
> I'll check; thanks for the report. Are you compiling with
> --disable-stack-for-recursion? That's the only time that heapframe
> should be used. However, the logic is contorted, to say the least. :-)
>
> > On another note, I could only build with SUPPORT_UCP defined if I also defined
> > SUPPORT_UTF8=1. That might actually be a bug?
>
> No; it is necessary to have SUPPORT_UTF8 in order to have SUPPORT_UCP.
> If you use the ./configure system, that happens automatically.
>
> Philip
>



I see, I configured using: "cmake -DSUPPORT_UCP=1 .". In that scenario my
build failed and I had to do "cmake -DSUPPORT_UCP=1 -DSUPPORT_UTF8=1 ."

I did not try compiling with --disable-stack-for-recursion.


--
Configure bugmail: http://bugs.exim.org/userprefs.cgi?tab=email