Re: [exim] [PATCH] ratelimit improvements

Kezdőlap
Üzenet törlése
Válasz az üzenetre
Szerző: Tony Finch
Dátum:  
Címzett: Exim Mailing List
Tárgy: Re: [exim] [PATCH] ratelimit improvements
On Tue, 5 Feb 2008, Dean Brooks wrote:
>
> Hmmm. I use /per_rcpt in our acl_smtp_mail section, but I use the
> /noupdate tag to do a read-only read of the value. That way I can
> increment recipients at RCPT time, but I can reject future messages
> at MAIL time based upon previous rcpt counts.
>
> Would your change prevent this?


Ah, that's a very good point. I'll make this work again.

(The code had a comment speculating that better error checking might be
helpful, so I added checking in order to get rid of the comment -
forgetting that the /noupdate feature made the comment obsolete.)

> Are one of the three options required to be used, or will the default
> still be /leaky if none are specified?


Yes, /leaky is still the default.

> The only other consideration I can think of is to make sure exim_tidydb
> still properly tidies the ratelimit database properly. Without tidying,
> ratelimit databases can grow VERY large, especially if used on incoming
> MX mail.


All the hints database entries start with a timestamp, so exim_tidydb can
work using just this prefix - it doesn't need to know anything special
about the ratelimit database.

Thanks very much for your feedback.

Tony.
--
<fanf@???> <dot@???> http://dotat.at/ ${sg{\N${sg{\
N\}{([^N]*)(.)(.)(.*)}{\$1\$3\$2\$1\$3\n\$2\$3\$4\$3\n\$3\$2\$4}}\
\N}{([^N]*)(.)(.)(.*)}{\$1\$3\$2\$1\$3\n\$2\$3\$4\$3\n\$3\$2\$4}}