[exim-dev] [Bug 455] fakereject behaves differently than den…

Top Page

Reply to this message
Author: bug455
Date:  
To: exim-dev
Subject: [exim-dev] [Bug 455] fakereject behaves differently than deny message
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

http://www.exim.org/bugzilla/show_bug.cgi?id=455





------- Comment #5 from ph10@??? 2007-02-05 15:15 -------
I'm afraid I do not like this patch. Three reasons: (a) It changes the function
smtp_respond(), which currently does "output this text, respecting newlines"
into one that takes decisions about splitting the text. I'd rather have the
splitting decisions taken separately. (b) The output from an ACL does not
necessarily go through smtp_respond() - for a start, messages from acl_not_smtp
do not do so, nor do messages concerned with batched SMTP. (c) Because the
interaction between ACLs and smtp_respond() isn't clear, I suspect (but have no
hard evidence) that something is sure to break. (I note that you also had
doubts.)

I would rather arrange that fake_response_text was split up at the end of
acl_check(), in the same way that user_message is now. An obvious approach is
to to put the current inline text into a subroutine that is called for both
variables. That fixes the bug without disturbing anything else.

I don't particularly like the idea of breaking lines at separators. The
no_multiline thing is for *really* broken clients; I don't think they should be
sent long lines.

--
Configure bugmail: http://www.exim.org/bugzilla/userprefs.cgi?tab=email