Joachim,
Nice work on adding graphs to eximstats. I do have a couple of recommendations though -
* Add an explicit list of the Perl modules required (GD, GDTextUtil, GDGraph) to the POD docs and basic instructions on how to get/install them.
* Remove the warning flag from production code (I've had code break after Perl upgrades through leaving it in!)
Overall, it looks good to me!
Steve
> Subject:
>
> [Exim] Charts for eximstats
> From:
>
> Joachim Wieland <jwieland@???>
> Date:
>
> Sun, 31 Mar 2002 15:53:08 +0200
> To:
>
> exim-users@???
>
>
> Hi,
>
> I've enhanced the eximstats script to use the GD::Graph modules and create
> a few graphics. These are the new parameters:
>
> -charts Create charts (this requires the GD::Graph modules)
> -chartdir <dir> Create the charts' png files in the directory <dir>
> -chartrel <dir> Specify the relative directory for the "img src=" tags
> from where to include the charts in the html file
>
> You may run the script without GD::Graph modules as well, however the switches
> won't show any effect then.
>
> It creates complete pie charts for the transports table, a nicer version
> of the per hour histogram and pie charts for the top x of the top 50 where x
> is currently 5 (see variable $ntopchart in the script).
>
> Please test it and tell me if it works well for you.
>
> http://www.mcknight.de/exim/eximstats
>
> If it gets Philip's consent, I could also adapt eximstats.src.
>
>
> Joachim
>
> --
> *****PGP key available - send e-mail request***** - ICQ: 37225940
> If you must choose between two evils, pick the one you've never tried
> before.
>
